Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace python benchmark with cargo bench #318

Merged
merged 3 commits into from
Sep 14, 2023
Merged

replace python benchmark with cargo bench #318

merged 3 commits into from
Sep 14, 2023

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Jun 17, 2023

cargo bench is more rigorous than my home-built run-benchmarks.py.

This patch does this:

  • ports benchmark/run-benchmark.py to rust, specifically in the form of cargo bench benchmarks
  • moves all the environments (arguments) passed into the benchmark programs to be generated programatically. Currently they are being generated in clvm-form, compiled and then loaded from disk when running, which is slower.
  • pre-compiles the benchmark programs. compiling takes a surprisingly long time and there's no need to do that every CI run
  • drop dependencies on clvm and clvm_tools. The remaining dependency on opc is tests/run-programs.py. To make this available in CI, I install clvm_tools_rs

@coveralls-official
Copy link

coveralls-official bot commented Jun 19, 2023

Pull Request Test Coverage Report for Build 6186220250

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 45 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.8%) to 93.018%

Files with Coverage Reduction New Missed Lines %
src/chia_dialect.rs 5 67.52%
src/more_ops.rs 40 93.72%
Totals Coverage Status
Change from base Build 5953615517: -0.8%
Covered Lines: 5156
Relevant Lines: 5543

💛 - Coveralls

@arvidn arvidn force-pushed the clvm_tools branch 4 times, most recently from c234e56 to 17c6f13 Compare June 21, 2023 00:34
@arvidn arvidn changed the title drop dependency on clvm_tools replace python benchmark with cargo bench Jun 21, 2023
@arvidn arvidn marked this pull request as ready for review June 21, 2023 13:11
@arvidn arvidn force-pushed the clvm_tools branch 2 times, most recently from abe7d2c to c9a7e42 Compare June 21, 2023 15:27
@github-actions
Copy link

'This PR has been flagged as stale due to no activity for over 60
days. It will not be automatically closed, but it has been given
a stale-pr label and should be manually reviewed.'

@arvidn arvidn merged commit a2bdbc9 into main Sep 14, 2023
24 checks passed
@arvidn arvidn deleted the clvm_tools branch September 14, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants