Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop CI dependency on clvm_tools_rs #356

Merged
merged 1 commit into from
Dec 19, 2023
Merged

drop CI dependency on clvm_tools_rs #356

merged 1 commit into from
Dec 19, 2023

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Dec 19, 2023

It's only used by run-programs.py to compile .clvm -> .hex. This PR also checks-in the hex files.

The reason for this is to remove a cyclical dependency. clvm_tools_rs depends on this repository, which can cause issues when incompatible changes are made. e.g. https://github.com/Chia-Network/clvm_rs/actions/runs/7259364759/job/19776353813?pr=355

Copy link

coveralls-official bot commented Dec 19, 2023

Pull Request Test Coverage Report for Build 7260868619

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.8%) to 93.778%

Totals Coverage Status
Change from base Build 7158462817: 0.8%
Covered Lines: 5320
Relevant Lines: 5673

💛 - Coveralls

@arvidn arvidn force-pushed the drop-clvm-tools-rs branch 3 times, most recently from 35b2759 to 849ef22 Compare December 19, 2023 10:54
…y to compile .clvm -> .hex. But the hex files are already checked in.
@arvidn arvidn requested a review from Rigidity December 19, 2023 11:00
@arvidn arvidn marked this pull request as ready for review December 19, 2023 11:14
@arvidn arvidn merged commit d6b934d into main Dec 19, 2023
27 checks passed
@arvidn arvidn deleted the drop-clvm-tools-rs branch December 19, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants