Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use let-else to simplify code #367

Merged
merged 1 commit into from
Jan 31, 2024
Merged

use let-else to simplify code #367

merged 1 commit into from
Jan 31, 2024

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Jan 31, 2024

minor simplification

@arvidn arvidn requested a review from Rigidity January 31, 2024 13:00
Rigidity
Rigidity approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@Rigidity Rigidity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arvidn arvidn marked this pull request as ready for review January 31, 2024 13:03
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Jan 31, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7726605327

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 93.654%
Totals Coverage Status
Change from base Build 7505735168: -0.004%
Covered Lines: 5416
Relevant Lines: 5783
💛 - Coveralls

@arvidn arvidn merged commit 6e1106c into main Jan 31, 2024
23 checks passed
@arvidn arvidn deleted the let-else branch January 31, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rigidity Rigidity Rigidity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arvidn @Rigidity