Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[draft] [opinions welcome] Change the individual callback functions in run_program to a trait which simplifies lifetime management #398

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[draft] [opinions welcome] Change the individual callback functions in run_program to a trait which simplifies lifetime management #398

wants to merge 5 commits into from

Commits on Apr 25, 2024

  1. Callback as a trait implementation

    @prozacchiwawa
    prozacchiwawa committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    c6a423e View commit details
    Browse the repository at this point in the history

  2. fmt + clippy

    @prozacchiwawa
    prozacchiwawa committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    88f72e8 View commit details
    Browse the repository at this point in the history

  3. Add an index typedef and gate PreEvalResult properly

    @prozacchiwawa
    prozacchiwawa committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    23da9e1 View commit details
    Browse the repository at this point in the history

  4. Make smaller

    @prozacchiwawa
    prozacchiwawa committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    50902a7 View commit details
    Browse the repository at this point in the history

  5. Rename to row_index because it's more descriptive

    @prozacchiwawa
    prozacchiwawa committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    95b31a4 View commit details
    Browse the repository at this point in the history