Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend softfork test to cover the hard fork flag #405

Merged
merged 3 commits into from
May 15, 2024
Merged

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented May 15, 2024

This is to test the cases where we make the new operators available outside the softfork-guard.

We make sure they fail with "unknown operator" in mempool mode, and are treated as unknown in consensus (i.e. return NIL).

When the hard fork flag is set, we ensure they work as expected in both mempool and consensus mode.

Copy link

coveralls-official bot commented May 15, 2024

Pull Request Test Coverage Report for Build 9095271893

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.162%

Totals Coverage Status
Change from base Build 9086294840: 0.0%
Covered Lines: 5806
Relevant Lines: 6166

💛 - Coveralls

@arvidn arvidn marked this pull request as ready for review May 15, 2024 11:44
@arvidn arvidn requested a review from Rigidity May 15, 2024 11:44
Copy link
Contributor

@Rigidity Rigidity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit confusing to read at first, but makes sense now - lgtm

@arvidn arvidn merged commit 84410d9 into main May 15, 2024
27 checks passed
@arvidn arvidn deleted the softfork-test-hardfork branch May 15, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants