Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHIA-622 Fix openssl feature activation #430

Merged
merged 2 commits into from
Jul 10, 2024
Merged

CHIA-622 Fix openssl feature activation #430

merged 2 commits into from
Jul 10, 2024

Conversation

jack60612
Copy link
Contributor

No description provided.

@jack60612 jack60612 changed the title Fix openssl feature activation CHIA-622 Fix openssl feature activation Jul 10, 2024
@jack60612 jack60612 closed this Jul 10, 2024
@jack60612 jack60612 reopened this Jul 10, 2024
@jack60612 jack60612 requested a review from arvidn July 10, 2024 00:42
Rigidity
Rigidity approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@Rigidity Rigidity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, @arvidn what do you think

@jack60612 jack60612 requested a review from Rigidity July 10, 2024 00:42
@jack60612 jack60612 marked this pull request as ready for review July 10, 2024 00:42
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 9866238358

Details

  • 16 of 16 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 94.177%
Totals Coverage Status
Change from base Build 9866236250: 0.02%
Covered Lines: 5822
Relevant Lines: 6182
💛 - Coveralls

@jack60612 jack60612 added the bug Something isn't working label Jul 10, 2024
@jack60612 jack60612 mentioned this pull request Jul 10, 2024
Closed
arvidn
arvidn reviewed Jul 10, 2024
View reviewed changes
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! just one comment

src/sha2.rs Show resolved Hide resolved
arvidn
arvidn approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jack60612 jack60612 merged commit 4460b48 into main Jul 10, 2024
50 checks passed
@jack60612 jack60612 deleted the jn.openssl-chia_rs branch July 10, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

@Rigidity Rigidity Awaiting requested review from Rigidity

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jack60612 @arvidn @Rigidity