Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify (and optimize) decode_size_with_offset #470

Merged
merged 2 commits into from
Sep 23, 2024
Merged

simplify (and optimize) decode_size_with_offset #470

merged 2 commits into from
Sep 23, 2024

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Sep 23, 2024 •
edited
Loading

  • simplify tests for decode_size_with_offset() by parameterizing them
  • simplify parsing of length-prefix byte

This is best reviewed one commit at a time. The tests passed independently of the change to decode_size_with_offset().

@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Sep 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10988496880

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 94.008%
Totals Coverage Status
Change from base Build 10955322892: 0.03%
Covered Lines: 5695
Relevant Lines: 6058
💛 - Coveralls

@arvidn arvidn merged commit 10cc520 into main Sep 23, 2024
29 checks passed
@arvidn arvidn deleted the parse-atom branch September 23, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rigidity Rigidity Rigidity approved these changes

@richardkiss richardkiss Awaiting requested review from richardkiss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arvidn @Rigidity