-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement keccak256 operator and softfork #489
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11730142584Details
💛 - Coveralls |
Rigidity
force-pushed
the
keccak256-update
branch
from
October 31, 2024 04:18
0a6a3d3
to
2f413e7
Compare
arvidn
reviewed
Oct 31, 2024
arvidn
previously approved these changes
Nov 1, 2024
did you generate the fuzzing corpus and run the fuzzer for a while? |
arvidn
previously approved these changes
Nov 7, 2024
arvidn
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements CHIP-36, using the implementation originally provided by @arvidn in #403 for CHIP-34.
New operators
There is 1 new operator enabled under softfork
1
:keccak256
Cost
keccak256
As always, there's also a cost of 10 per byte that's allocated for the return value.
Activation
Since this is a softfork, the extension will only be available when the
ENABLE_KECCAK
flag is set, which it will be after the softfork activates.The operators will only be available for programs (
<prg>
) executing under(softfork <cost> 1 <prg> <arg>)
Hard fork
There's an option to hard-fork these operators out of the softfork-guard by specifying
ENABLE_KECCAK_OPS_OUTSIDE_GUARD
.Tests
The test vectors are generated using the python wheel
from eth_hash.auto import keccak
.