feat(): add farmer protocol #120
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n33pm
force-pushed
the
farmer-protocol
branch
2 times, most recently
from
fd0ad2f to
0023c26
Compare
|
Hey @n33pm - Just wanted to check on your progress here. Did you need the network with the lower filter for testing or did you find a way to test otherwise? |
| @@ -79,6 +89,23 @@ func NewConnection(ip *net.IP, options ...ConnectionOptionFunc) (*Connection, er | |||
| return c, nil | |||
| } | |||
|
|
|||
| // NewServerConnection creates a new connection object with the specified peer | |||
| func NewServerConnection(conn *websocket.Conn, options ...ConnectionOptionFunc) (*Connection, error) { | |||
There was a problem hiding this comment.
Just curious when the case is we already have a websocket connection vs an IP to connect to?
Is there a reason we can't just use the peerPort for this? I don't really see a difference between serverPort and peerPort (and they default to the same config value unless overridden with config option)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.