-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make /etc a subvolume that needs no mounting #59
Conversation
|
||
# copy the machine-id file: this was created by systemd the very first boot and identify the machine: | ||
# changing this will also make ssh warn about machine not matching. | ||
if [ -f "/etc/machine-id" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary? Do we have a mchine-id in our system image such that this would get overwritten? If we do, we should remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR, as the hibernation one, was superceeded by the upcoming frzr rework. Machine-id file is created at first boot by systemd on the first boot. I don't know if we have one in our image, but for sure it is something to investigate.
However I don't think we have one simply because systemd is not run from arch-chroot.
Moreover after a system restore the macchine changes id and SSH complains, so I think this is an indirect proof that wedon't ship such a file.
This introduces complexity which I am not comfortable with. "Distributing updates to /etc" which will overwrite user's configuration is not something I think we need or should do. I would much prefer to keep the overlay system we have now. If there is an issue with it, we should try to fix that. |
The problem is articulated in two points, and 3 solutions exists.
In the case of 2 we can carry over the password as well as machine-id |
This is meant to solve the /etc mounting issue where the /etc overlay fires off some race conditions with the system loading resulting in the infamous "gamer is not the password".
This also deals with the overlays that prevents chimeraos team to effectively distribute updates that needs /etc changes.