Change the downloader default GUI #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default mode being suitable for the installer (not showing download progress) is not good for using frzr via terminal: use whiptail GUI by default
|
I would not default to whiptail, why not the same as it was before? Just the wget output and the |
Important question: do we want whiptail at all? |
|
The new installer won't use whiptail anymore, we're going to update state from ENV. |
I understand this. The current behaviour is assuming frzr is being run by the installer and this commit changes back to assuming an Hunan via CLI when not told otherwise to have the old GUI. If whiptail is not needed anymore I will replace whiptail with textual output. |
- introduce FRZR_INSTALLER to flag for the presence of the GUI installer - use curl by default if frzr deploy is used by CLI
BoukeHaarsma23
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default mode being suitable for the installer (not showing download progress) is not good for using frzr via terminal: use whiptail GUI by default