Bug fixes and verious improments #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you please split this out to multiple commits? |
Multiple commits or multiple PRs ? |
|
commits |
The following has been implemented - Introduce a test for the permission error - Change tests to use the makefile installation
frzr would fail if the tracker file is created by a user and overwritten by another user, even if such user is root. Solve the problem by: - moving the file into a directory the whole frzr group has read+write access to - make the file owned by the frzr group
Fix the improper whiptail usage by ensuring SHOW_UI variable is set to 0 as stated into the command help
|
Re: whiptail usage. That should only be used for the installer. For CLI use we just want to print to stdout and for steam use we have the special mode. Everything else is OK for me. |
This patch makes whiptail only used when SHOW_UI is set to 1 (the installer). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following has been implemented
not being set to zero when unspecified