Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for native-base-shoutem-theme to native-base-web components #18

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

flipflopapp
Copy link

I have added support for native-base-shoutem-theme and recompiled the lib folder with the changes.

By comparing native-base and native-base-web, I saw that the support for native-base-shoutem-theme is missing. For instance, in file native-base/src/button.js; the following code is added to support shoutem-theme.

import { connectStyle } from "native-base-shoutem-theme";
...
// and at the end...
const StyledButton = connectStyle(
  "NativeBase.Button",
  {},
  mapPropsToStyleNames
)(Button);
export { StyledButton as Button };

The component file Components/Widgets/Button.js in 'native-base-web' is missing this connector.

I have added the missing connector in the pull request.

@flipflopapp flipflopapp changed the title Added support for native-base-shoutem-theme to react-native-web components Added support for native-base-shoutem-theme to native-base-web components Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant