Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw situation fixed #535

Merged
merged 2 commits into from
Jul 21, 2024
Merged

Draw situation fixed #535

merged 2 commits into from
Jul 21, 2024

Conversation

hars-21
Copy link
Contributor

@hars-21 hars-21 commented Jul 19, 2024

PR Description 📜

Successfully fixed the bug where the draw condition is giving a win condition for one player.
Now if the scores are same then the game returns draw.
Bugs Fixed

Fixes #458


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for review.

## Add your screenshots(Optional) 📸

Screen Shot 2024-07-19 at 5 01 55 PM



Thank you soo much for contributing to our repository 💗

@hars-21
Copy link
Contributor Author

hars-21 commented Jul 20, 2024

@ayush-t02 Please review this PR. I have fixed the draw situation

@ayush-t02 ayush-t02 merged commit 547251d into ChromeGaming:main Jul 21, 2024
@hars-21 hars-21 deleted the draw branch July 31, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: When both have same score , if match ends it should give as tie / draw
2 participants