Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the Bug in Contributors Data Fetching #725

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

RadhikaMalpani1702
Copy link
Contributor

PR Description 📜

Hey @ayush-t02

I have fixed the bug in contributors data fetching

  • fetchContributors: Fetches all contributors from the GitHub API and stores them in totalContributors.
  • updateContributors: Updates the displayed contributors based on the current page and the number of contributors per page.
  • Pagination: Adds event listeners to the "Previous" and "Next" buttons to navigate through pages, updating the contributors' display and enabling/disabling buttons as necessary.

This approach ensures that we display 30 contributors per page and navigate through them efficiently.

dot.1.mp4

Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for review.


Thank you soo much for contributing to our repository 💗

@ayush-t02 ayush-t02 merged commit 3e691a6 into ChromeGaming:main Aug 7, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in Contributors Data Fetching
2 participants