Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win Overlay updated #736

Merged
merged 4 commits into from
Aug 9, 2024
Merged

Win Overlay updated #736

merged 4 commits into from
Aug 9, 2024

Conversation

hars-21
Copy link
Contributor

@hars-21 hars-21 commented Aug 8, 2024

PR Description 📜

Updated the win overlay with new confetti animation.
Added a new pop sound effect.
Scoreboard is now visible on win overlay.

Fixes #676


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for review.

## Add your screenshots(Optional) 📸

Screen Shot 2024-08-08 at 5 02 49 PM
Screen Shot 2024-08-08 at 5 02 51 PM



Thank you soo much for contributing to our repository 💗

@ayush-t02
Copy link
Collaborator

resolve conflicts

@hars-21
Copy link
Contributor Author

hars-21 commented Aug 9, 2024

@ayush-t02 Fixed. Please review

@ayush-t02 ayush-t02 merged commit 4ab385e into ChromeGaming:main Aug 9, 2024
@hars-21 hars-21 deleted the overlay branch August 9, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Winner Overlay UI enhancement
2 participants