Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug_fix] Updated README to match RedHat's ansible collection template (DCNE-198) #692

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samiib
Copy link
Collaborator

@samiib samiib commented Oct 11, 2024

Readme should match this template https://access.redhat.com/articles/7068606

@samiib samiib self-assigned this Oct 11, 2024
@samiib samiib added the documentation Improvements or additions to documentation label Oct 11, 2024
@samiib samiib marked this pull request as ready for review October 14, 2024 09:53
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
akinross
akinross previously approved these changes Oct 15, 2024
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol previously approved these changes Oct 15, 2024
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akinross
Copy link
Collaborator

Should we add a link to the following page https://github.com/shrsr/ansible/blob/devel/docs/docsite/rst/dev_guide/developing_modules_general_aci.rst?

@samiib
Copy link
Collaborator Author

samiib commented Oct 16, 2024

Should we add a link to the following page https://github.com/shrsr/ansible/blob/devel/docs/docsite/rst/dev_guide/developing_modules_general_aci.rst?

@akinross I think this is a really great documentation, we should add to the wiki of this repo or as another markdown in this repo.

@akinross
Copy link
Collaborator

Should we add a link to the following page https://github.com/shrsr/ansible/blob/devel/docs/docsite/rst/dev_guide/developing_modules_general_aci.rst?

@akinross I think this is a really great documentation, we should add to the wiki of this repo or as another markdown in this repo.

Yes this is written by @shrsr a long time ago but should have been included in the repo. I now have had multiple occasions where people wanting to contribute were not aware so think we should be more vocal about this. #278 is actually sort of tracking it already I think

shrsr
shrsr previously approved these changes Oct 17, 2024
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated
Comment on lines 85 to 99
### Second Approach
## Use Cases

Once the collection is installed, you can use it in a playbook by specifying the full namespace path to the module, plugin and/or role.

### Adding a new EPG

Go to [ansible-aci Actions](https://github.com/CiscoDevNet/ansible-aci/actions)
```yml
- hosts: aci
gather_facts: no

Select the latest CI build
tasks:
- name: Add a new EPG
cisco.aci.aci_epg:
hostname: apic
username: admin
password: SomeSecretPassword
tenant: production
ap: intranet
epg: web_epg
description: Web Intranet EPG
bd: prod_bd
delegate_to: localhost
```

Under Artifacts download collection and unzip it using Terminal or Console.
## Optimizing Playbooks

*Note: The collection file is a zip file containing a tar.gz file. We recommend using CLI because some GUI-based unarchiver might unarchive both nested archives in one go.*
There are two main methods to optimize the execution of ACI modules in your playbooks.

Install the unarchived tar.gz file
1. Using the ACI HTTPAPI plugin
1. Using the `suppress_` options

```sh
ansible-galaxy collection install cisco-aci-1.0.0.tar.gz —-force
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removing this second approach?

Copy link
Collaborator Author

@samiib samiib Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akinross and I agreed, that since the builds aren't consistently green due to the integration tests that we wouldn't recommend doing it this way anymore.
#692 (comment)
The idea was to add a nightly dev build that gets published instead. Not sure if this is possible with Ansible Galaxy but thought I would add a backlog item for it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would the nightly be different from the CI actions downloads and how is it different from building from source in regard to the integration tests?

How are we tracking this nightly suggestion?

Until we have the nightly available more easily I would keep that in.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved

*Note: This collection is not compatible with versions of Ansible before v2.8.*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, we should still keep this note somewhere in readMe

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already mention in the requirements section that the collection requires Ansible v2.15+
v2.8 has been EOL for almost 3 years now. I think its okay to remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants