Added modules to manage Endpoint IP and MAC Tags (DCNE-287) #723
+1,389
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sajagana
requested review from
akinross,
anvitha-jain,
gmicol,
lhercot,
samiib and
shrsr
as code owners
github-actions
bot
changed the title
akinross
requested changes
Feb 19, 2025
…_tag, aci_endpoint_mac_tag modules
…aci_endpoint_mac_tag modules
sajagana
force-pushed
the
714_endpoint_policy_tags
branch
from
cfd740b to
c333366
Compare
samiib
requested changes
Feb 25, 2025
Comment on lines
+283
to
+290
| - query_with_vrf.current | length >= 1 | ||
| - query_with_ip is not changed | ||
| - query_with_ip.current | length >= 2 | ||
| - query_all_ip_tags_1 is not changed | ||
| - query_all_ip_tags_1.current != [] | ||
| - query_all_ip_tags_1.current | length >= 3 | ||
| - nt_query_ip_tag is not changed | ||
| - nt_query_ip_tag.current == [] |
There was a problem hiding this comment.
Should we check to make sure the returned objects are the expected objects?
Should we also check to make sure the lengths are exactly what we expect?
eg.
Suggested change
| - query_with_vrf.current | length >= 1 | |
| - query_with_ip is not changed | |
| - query_with_ip.current | length >= 2 | |
| - query_all_ip_tags_1 is not changed | |
| - query_all_ip_tags_1.current != [] | |
| - query_all_ip_tags_1.current | length >= 3 | |
| - nt_query_ip_tag is not changed | |
| - nt_query_ip_tag.current == [] | |
| - query_with_vrf.current | length == 1 | |
| - query_with_vrf.current.0 == add_ip_tag_2.current | |
| - query_with_ip is not changed | |
| - query_with_ip.current | length == 2 | |
| - query_with_ip.current.0 == nm_update_ip_tag_1.current | |
| - query_with_ip.current.1 == add_ip_tag_3.current | |
| - query_all_ip_tags_1 is not changed | |
| - query_all_ip_tags_1.current != [] | |
| - query_all_ip_tags_1.current | length == 3 | |
| - query_all_ip_tags_1.current.0 == nm_update_ip_tag_1.current | |
| - query_all_ip_tags_1.current.1 == add_ip_tag_2.current | |
| - query_all_ip_tags_1.current.2 == add_ip_tag_3.current | |
| - nt_query_ip_tag is not changed | |
| - nt_query_ip_tag.current == [] |
Comment on lines
+290
to
+296
| - query_with_bd.current | length >= 1 | ||
| - query_with_mac is not changed | ||
| - query_with_mac.current | length >= 2 | ||
| - nt_query_mac_tag is not changed | ||
| - nt_query_mac_tag.current == [] | ||
| - query_all_mac_tags_1 is not changed | ||
| - query_all_mac_tags_1.current | length >= 3 |
There was a problem hiding this comment.
Checking the correct objects are returned would also be good here too.
Also can we check for exact lengths?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.