[bug_fix] Fix importing for mso_schema_template_anp_epg_contract to select the contract with the correct type (DCNE-205) #299
Conversation
…elect the contract with the correct type
akinross
requested review from
lhercot,
shrsr,
anvitha-jain,
sajagana,
samiib and
gmicol
I see when looking at git blame that the relationship_type is already part of the original code from 4 years ago and is also part of the read function. I assumed ( perhaps wrongly ) that since it is already done also in the read function this is missing in import only by mistake. If it was introduced at a later stage in NDO/MSO then I think it is already broken for the read function for a while, and thus the resource should not be working properly in older versions. I can look up when this is introduced, will look through release notes and get back to you. |
|
@anvitha-jain Are you referring to the the resource in Terraform ACI that you worked on? |
|
I think we are mixing it up with the template contract resource filterRelationships, filterRelationshipsConsumerToProvider and filterRelationshipsProviderToConsumer attributes which are separate lists. The only issue that could exist here is that there are other values for relationship_type in the API documentation and we are not listing them all. |
| @@ -45,5 +45,5 @@ No attributes are exported. | |||
| An existing MSO Schema Template Application Network Profile Endpoint Group Contract can be [imported][docs-import] into this resource via its Id/path, via the following command: [docs-import]: <https://www.terraform.io/docs/import/index.html> | |||
|
|
|||
| ```bash | |||
| terraform import mso_schema_template_anp_epg_contract.contract1 {schema_id}/template/{template_name}/anp/{anp_name}/epg/{epg_name}/contract/{contract_name} | |||
| terraform import mso_schema_template_anp_epg_contract.contract1 {schema_id}/template/{template_name}/anp/{anp_name}/epg/{epg_name}/contract/{contract_name}/relationship_type/{consumer|provider} | |||
There was a problem hiding this comment.
| terraform import mso_schema_template_anp_epg_contract.contract1 {schema_id}/template/{template_name}/anp/{anp_name}/epg/{epg_name}/contract/{contract_name}/relationship_type/{consumer|provider} | |
| terraform import mso_schema_template_anp_epg_contract.contract1 {schema_id}/template/{template_name}/anp/{anp_name}/epg/{epg_name}/contract/{contract_name}/relationshipType/{consumer|provider} |
fixes #298