SIMPLE-6087 creating a lab no longer raises a warning (#74)

* SIMPLE-6087 creating a lab no longer raises a warning --------- Co-authored-by: tmikuska <[email protected]>
CiscoDevNet · Dec 8, 2023 · 791efb9 · 791efb9
1 parent 2136fc3
commit 791efb9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/virl2_client/models/lab.py b/virl2_client/models/lab.py
@@ -1188,11 +1188,14 @@ def _import_lab(self, topology: dict) -> None:
         lab_dict = topology.get("lab")
 
         if lab_dict is None:
-            warnings.warn(
-                "Labs created in older CML releases (schema version 0.0.5 or lower) "
-                "are deprecated. Use labs with schema version 0.1.0 or higher.",
-                DeprecationWarning,
-            )
+            # If we just created the lab, we skip the warning, since the
+            # lab post endpoint returns data in the old format
+            if not topology.pop("_created", False):
+                warnings.warn(
+                    "Labs created in older CML releases (schema version 0.0.5 or lower)"
+                    " are deprecated. Use labs with schema version 0.1.0 or higher.",
+                    DeprecationWarning,
+                )
             self._title = topology["lab_title"]
             self._description = topology["lab_description"]
             self._notes = topology["lab_notes"]

diff --git a/virl2_client/virl2_client.py b/virl2_client/virl2_client.py
@@ -721,6 +721,8 @@ def create_lab(
             wait_time=self.convergence_wait_time,
             resource_pool_manager=self.resource_pool_management,
         )
+        # This is just to skip a deprecation warning in _import_lab
+        result["_created"] = True
         lab._import_lab(result)
         self._labs[lab_id] = lab
         return lab