Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8670 Hero image author #814

Merged
merged 6 commits into from
Sep 24, 2024
Merged

UHF-8670 Hero image author #814

merged 6 commits into from
Sep 24, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Sep 20, 2024

UHF-8670

What was done

  • Added getter methods to Hero bundle class for getting image, image author, description and title.
  • Added a preprocess for the Hero paragraph and added the image_author variable for the templates.
  • Added translations for image author field.
  • Fixed deprecated translatable string for category field.
  • Added tests for Hero bundle class and Hero design alter function.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config and the HDBT theme
    • composer require drupal/helfi_platform_config:dev-UHF-8670 drupal/hdbt:dev-UHF-8670
  • Run make drush-updb drush-cr

How to test

  • Go to some page with Hero and check that the image author text has appeared. See screenshot below.

    image

  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

Copy link

sonarcloud bot commented Sep 20, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants