Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10461: Add support for language direction by rewriting whole editor. #822

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

Arkkimaagi
Copy link
Contributor

@Arkkimaagi Arkkimaagi commented Oct 8, 2024

UHF-10461

  • Cookie banner did not support language directions or language attributes for screen readers
  • The editor did not save language options properly to json, so adding languages was inpossible.

What was done

  • Whole editor was rewritten
  • json syntax was updated
  • banner code was updated

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-10461_fixed_cookie_banner_editor
  • Run make drush-updb drush-cr

How to test

  • Check that this feature works
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

  • Link to other PR

@Arkkimaagi Arkkimaagi force-pushed the UHF-10461_fixed_cookie_banner_editor branch from ebd8de6 to 9b6e2b2 Compare October 8, 2024 06:06
Copy link

sonarcloud bot commented Oct 8, 2024

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Let's merge this. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants