Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-8650 Preparation for the HDS cookie banner module #832

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

UHF-8650 Preparation for the HDS cookie banner module #832

wants to merge 40 commits into from
+816 −355

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Oct 21, 2024 •
edited by jira bot
Loading

UHF-8650

What was done

  • Renamed the cookie policy to cookie settings.
  • Added default JSON without any cookies to "site_settings". This will prevent the JSON validation bug when enabling site specific cookie settings.
  • Changed the cookie policy page controller to cookie settings page controller.
  • Converted the cookie banner attachment to a service.
  • Added install hooks for the cookie banner module and uninstall hook for the helfi eu cookie compliance module.
  • Added tests for the Cookie settings service.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-8650 drupal/hdbt:dev-UHF-8650 -W
  • Run make drush-updb drush-cr

How to test

Check testing instructions from City-of-Helsinki/drupal-hdbt#1083

Other PRs

Arkkimaagi and others added 17 commits October 11, 2024 10:02
@Arkkimaagi
UHF-8650: Switch react and share to use hds cookie banner
070f189
@khalima
UHF-8650: Renamed the cookie policy to cookie settings.
656197d
@khalima
UHF-8650: Fixed PHPStan and PHPCS errors from hel_map.
aca5b0e
@khalima
UHF-8650: Added default JSON without any cookies to "site_settings". …
a457a83 
…This will prevent the JSON validation bug when enabling site specific cookie settings.
@khalima
UHF-8650: Changed the cookie policy page controller to cookie setting…
062b2f7 
…s page controller.
@khalima
UHF-8650: Converted the cookie banner attachment to a service.
c1e4bae
@khalima
UHF-8650: Use KernelTestBase instead of cookie banner kernel test base.
fdd401a
@khalima
UHF-8650: Added install hooks for the cookie banner module.
6f2638f
@khalima
UHF-8650: Define the cookie banner services.
bc37c57
@khalima
UHF-8650: Added tests to the Cookie settings service.
b90466c
@khalima
UHF-8650: Get the cookie settings page URL via cookie_settings service.
1f7252f
@khalima
UHF-8650: Removed todo comment.
46037d5
@khalima
UHF-8650: Added a fallback for the helfi_react_search cookie privacy …
01eb14d 
…URL.
@khalima
UHF-8650: Added uninstall hook to remove all obsolete configurations.
709a400
@khalima
UHF-8650: Use HDBT cookie banner cookie settings URL if available. Ot…
9e84cf8 
…herwise, fallback to helfi_eu_cookie_compliance private policy URL.
@khalima
UHF-8650: Check if privacy_policy_url exists.
a8987cf
@khalima
UHF-8650: More consistent todo messages to help the spring-cleaning.
4518f94
@khalima khalima mentioned this pull request Oct 21, 2024
Open
40 tasks
@khalima
UHF-8650: Use MediaEntityBundle base class to minimize the duplicated…
c0654a2 
… code.
@khalima
UHF-8650: Merge branch 'UHF-8650_cookie_banner_activation' of https:/…
58ac6b2 
…/github.com/City-of-Helsinki/drupal-helfi-platform-config into UHF-8650
@khalima
UHF-8650: Added Drupal.cookieConsent global status handlers.
878b262
@khalima
UHF-8650: Get consent statuses via the global Drupal.cookieConsent ob…
bf2246c 
…ject.
@khalima
UHF-8650: Load the cookie banner JS files in HEAD.
9f23507
@khalima
UHF-8650: Converted the cookie_privacy_url to string.
50a5dc1
@khalima
UHF-8650: Fixed the weights for the cookieConsent files and added uni…
0029824 
…versal helper functions.
@khalima
UHF-8650: Use global Drupal.cookieConsent functions to check the cons…
b87aea2 
…ent status.
@khalima
UHF-8650: Fixed the setAcceptedCategories callback.
feaab60
@khalima
UHF-8650: Use global Drupal.cookieConsent functions to check the cons…
9cd727e 
…ent statuses. Use correct dependencies when loading the chart library.
@khalima
UHF-8650: Merge branch 'UHF-8650' of https://github.com/City-of-Helsi…
6885ef4 
…nki/drupal-helfi-platform-config into UHF-8650
@khalima khalima mentioned this pull request Oct 23, 2024
Closed
@khalima khalima requested a review from tuutti October 23, 2024 14:26
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 24, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuutti tuutti Awaiting requested review from tuutti

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khalima @tuutti @Arkkimaagi