Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10079, UHF-10045 #332

Merged
merged 14 commits into from
Sep 23, 2024
Merged

UHF-10079, UHF-10045 #332

merged 14 commits into from
Sep 23, 2024

Conversation

hyrsky
Copy link
Contributor

@hyrsky hyrsky commented Aug 26, 2024

UHF-10079

What was done

  • Install helfi_users module from helfi_platform_config.

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout dev
    • make fresh
    • git checkout UHF-10045
    • composer install
    • composer update drupal/helfi_platform_config
    • drush ev "\Drupal::service('update.update_hook_registry')->setInstalledVersion('helfi_ckeditor', 9009);"
      • Update hooks from 4.3.26 are already executed.
    • drush deploy
  • Run make drush-cr

How to test

Review changes to helfi_ckeditor in helfi_platform_config:

  • git diff 4.3.26..main modules/helfi_ckeditor. Is there anything that breaks in Infofinland?
  • Edit & save a node in Drupal
  • Build frontend

Artifact needs to be built from this branch for tests to complete.

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

@hyrsky hyrsky marked this pull request as ready for review September 18, 2024 09:46
Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to work the same way as in current production environment. Good job! 🚀

Copy link

sonarcloud bot commented Sep 23, 2024

@hyrsky hyrsky merged commit 1ab8517 into dev Sep 23, 2024
3 checks passed
@hyrsky hyrsky deleted the UHF-10045 branch September 23, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants