HAI-2749 Use data instead of entity for hakemus update change check #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corvidian
force-pushed
the
HAI-2749/compare-hakemus-update-changes-against-hakemusdata
branch
from
90e7eed
to
4a8f392
Compare
Compare the hakemus update to a ` HakemusData` instead of an `ApplicationEntity` when checking if the update has any changes. This allows the same method to be used to check if a täydennys has any changes over the original hakemus or the previously saved täydennys.
corvidian
force-pushed
the
HAI-2749/compare-hakemus-update-changes-against-hakemusdata
branch
from
4a8f392
to
b949e26
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Compare the hakemus update to a
HakemusDatainstead of anApplicationEntitywhen checking if the update has any changes.This allows the same method to be used to check if a täydennys has any changes over the original hakemus or the previously saved täydennys.
Jira Issue: https://helsinkisolutionoffice.atlassian.net/browse/HAI-2749
Type of change
Instructions for testing
Should work like before.
Checklist:
or other location: