Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky tests #168

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Fix flaky tests #168

merged 3 commits into from
Dec 3, 2024

Conversation

danipran
Copy link
Contributor

@danipran danipran commented Dec 2, 2024

(Split from #165)

Running pytest would work, but not pytest -k contractor. This PR makes various fixes to fix the flakiness of the tests and other refactoring.

Also fixes a broken warning that came up while fixing the tests.

Use anonymous instead of unauthenticated,
fix one case with an incorrect label
(says unauthenticated user, but uses an
authenticated user)

Refs: PS-160, PS-159
Refs: PS-160, PS-159
@danipran danipran requested a review from a team December 2, 2024 07:40
@terovirtanen
Copy link
Contributor

PUISTOTALKOOT-API branch is deployed to platta: https://puistotalkoot-pr168.api.dev.hel.ninja 🚀🚀🚀

events/factories.py Outdated Show resolved Hide resolved
Running `pytest` would work, but not `pytest -k contractor`.
This commit makes various fixes to fix the flakiness of the
tests.

Refs: PS-160, PS-159
@terovirtanen
Copy link
Contributor

PUISTOTALKOOT-API branch is deployed to platta: https://puistotalkoot-pr168.api.dev.hel.ninja 🚀🚀🚀

Copy link
Contributor

@tuomas777 tuomas777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements 💯

@danipran danipran merged commit 0552e29 into main Dec 3, 2024
26 checks passed
@danipran danipran deleted the fix-tests branch December 3, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants