Optimize copy opening hours #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirkkahuhtala
force-pushed
the
feature/optimize-copy-opening-hours
branch
2 times, most recently
from
50bb60b to
5c73a60
Compare
pirkkahuhtala
force-pushed
the
feature/optimize-copy-opening-hours
branch
5 times, most recently
from
6e5a118 to
3148e25
Compare
pirkkahuhtala
force-pushed
the
feature/optimize-copy-opening-hours
branch
5 times, most recently
from
2c163c0 to
fefc7fe
Compare
pirkkahuhtala
force-pushed
the
feature/optimize-copy-opening-hours
branch
8 times, most recently
from
5d4cd80 to
7ef21e8
Compare
pirkkahuhtala
commented
Jan 10, 2023
| if target_resources.count() != len(target_resource_ids): | ||
| for target_resource_id in target_resource_ids: | ||
| try: | ||
| Resource.objects.get(**get_resource_pk_filter(target_resource_id)) |
There was a problem hiding this comment.
This is something I would have liked to do so that we would not need to do another select for getting the non-found resources.
pirkkahuhtala
force-pushed
the
feature/optimize-copy-opening-hours
branch
from
7ef21e8 to
e0c84de
Compare
pirkkahuhtala
force-pushed
the
feature/optimize-copy-opening-hours
branch
from
e0c84de to
0511f3b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
pirkkahuhtala
commented
Mar 9, 2023
| from django.db import models | ||
| from django.utils.translation import gettext_lazy as _ | ||
| from helusers.models import AbstractUser | ||
|
|
||
|
|
||
| class CustomUserManager(UserManager): | ||
| def get(self, *args, **kwargs): |
There was a problem hiding this comment.
The intent here was to try to optimise the permission check a bit so that it would not need to fetch the user orgs every time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.