New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow submitting form while community_practices_business is null #1503

Open

jeremysteerio wants to merge 1 commit into develop from fix_community_practices_business_submit

+8 −2

jeremysteerio commented Oct 11, 2024 •

edited

Loading

UHF-0000

User was able to submit form without ticking community_practices_business option. Fixed by making form validation stricter.

What was done

Fix logic that sets the value when not present
Make validation stricter

How to install

Make sure your instance is up and running on correct branch.
- git checkout origin/fix_community_practices_business_submit
- make fresh
Run make drush-cr

How to test

Log in with Suomi.fi authentication https://hel-fi-drupal-grant-applications.docker.so/fi/user/login

Designers review

This PR does not need designers review
This PR has been visually reviewed by a designer (Name of the designer)

Automatic- / Regression tests

This PR makes no changes that effects any tests. (This will be caught in automatic testing later on, but please, please run regression tests always on PR before asking for a review)
This PR passes regression tests. (make test-pw)


          Disallow submitting form while community_practices_business is null

6823f39

sonarcloud bot commented Oct 11, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet