fix: fixed dependency array not having variables that require init (#…

…1096) * fix: fixed dependency array not having variables that require init * fix: fixing comment tests failing if only one comment is written
City-of-Helsinki · Nov 26, 2024 · 5aee858 · 5aee858
1 parent 25a49bb
commit 5aee858
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/e2e/tests/pages/hearing.spec.js b/e2e/tests/pages/hearing.spec.js
@@ -39,7 +39,7 @@ test.describe('Hearing', () => {
   });
 
   test('should display comment count', async () => {
-    await expect(page.getByTestId('comment-summary')).toContainText(`Yhteensä ${hearing.n_comments} kommenttia`);
+    await expect(page.getByTestId('comment-summary')).toContainText(`Yhteensä ${hearing.n_comments} kommentti`);
   });
 
   test('should have Swedish link if available', async () => {

diff --git a/src/components/admin/HearingEditor.jsx b/src/components/admin/HearingEditor.jsx
@@ -87,7 +87,8 @@ const HearingEditor = (props) => {
         setShouldSubmit(false);
       }
     }
-  }, [shouldSubmit, editorErrors, errors, editorIsSaving, hearing.slug, language, navigate]);
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, [shouldSubmit, editorErrors, errors, editorIsSaving, language, navigate]);
 
 
   /**