LINK-2210: fix randomly failing tests #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: LINK-2210
This was causing failures with two tests which assume that the notifications were sent in a certain order (desc pk). However, if an order is not specified, Postgres cannot guarantee an order, and that's exactly what happened here. There were two ways of resolving this; either guarantee an order or change the test to be order-agnostic. In this case, I chose the path of least resistance. Refs: LINK-2210
|
|
LINKEDEVENTS-API branch is deployed to platta: https://linkedevents-pr1022.api.dev.hel.ninja 🚀🚀🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing random failures with two tests (
test_recurring_sub_event_put_cancellation_emails_sent_payments_not_refunded_for_super_eventandtest_recurring_sub_event_put_cancellation_emails_sent_signups_not_cancelled_for_super_event) which assume that the notifications were sent in a certain order (desc pk). However, if an order is not specified, Postgres cannot guarantee an order, and that's exactly what happened here.There were two ways of resolving this; either guarantee an order or change the test to be order-agnostic. In this case, I chose the path of least resistance.
I've no clue how to default order works, but it's probably related to the underlying data structures. It would also explain why the tests were failing randomly since there is some random data involved in the tests (e.g. factories & Faker).
I was able to replicate the issue locally (using Docker) by running only the two tests with the same database (i.e.
--reuse-dbflag with pytest, need to do the first run with--create-dbto recreate the database) 20 times in a row. From the 21st run onward, the two tests start to fail. I realize this sounds more like an urban legend than actual steps for replicating this, but I was able to do this consistently. Not sure if it works on every machine since Postgres' default order is something of a mystery (or for me, at least).Also fixed a misnamed init file.