Create control share validation #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinikvuo
force-pushed
the
feature-controshare-validation
branch
4 times, most recently
from
f996032
to
511bfd1
Compare
Codecov Report
@@ Coverage Diff @@
## develop #511 +/- ##
===========================================
+ Coverage 75.68% 75.72% +0.03%
===========================================
Files 439 438 -1
Lines 23095 23127 +32
Branches 2314 2321 +7
===========================================
+ Hits 17480 17512 +32
- Misses 5178 5179 +1
+ Partials 437 436 -1
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| ]["hallintaosuus"] = {"value": "1/3", "extraValue": ""} | ||
| answer_serializer = AnswerSerializer(data=answer_data) | ||
|
|
||
| # test that a incorrectly formatted ssn is caught by the validator |
There was a problem hiding this comment.
The comment is copypasted from previous test. Maybe something like "test that control share validator returns validation error if the sum is not 1"
| if round(result, 10) != 1: | ||
| raise ValidationError(code="control share is not even") | ||
|
|
||
| def control_share_finder_generator(self, entries): |
There was a problem hiding this comment.
Ooo, nice generator function :D
PasiVuohijoki
approved these changes
Aug 22, 2023
vinikvuo
force-pushed
the
feature-controshare-validation
branch
from
511bfd1
to
ce14d83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.