Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "require adult reservee" checks #1462

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add "require adult reservee" checks #1462

wants to merge 4 commits into from

Conversation

matti-lamppu
Copy link
Collaborator

@matti-lamppu matti-lamppu commented Dec 11, 2024 •
edited by jira bot
Loading

🛠️ Changelog

  • Add an option for requiring adult reservees for some reservation units by setting an option on the reservation unit
  • Check user age in (tentative) reservation create endpoint if this setting is on
  • Also check age when creating applications
  • Allow AD users to bypass these checks, since we cannot check their birthdays. We have banned students from signing in via AD accounts, so all AD users should be of age.

🧪 Test plan

  • Automated tests

🚧 Dependencies

  • None

🎫 Tickets

@matti-lamppu matti-lamppu added the feature Adds a new feature label Dec 11, 2024
@matti-lamppu matti-lamppu self-assigned this Dec 11, 2024
@matti-lamppu matti-lamppu force-pushed the require-age-check-for-reservation-units branch from 33a970d to 5612989 Compare December 11, 2024 08:18
@matti-lamppu matti-lamppu marked this pull request as ready for review December 11, 2024 08:28
@matti-lamppu matti-lamppu force-pushed the require-age-check-for-reservation-units branch 2 times, most recently from 3dc60f9 to ddc5e74 Compare December 16, 2024 12:27
@matti-lamppu matti-lamppu force-pushed the require-age-check-for-reservation-units branch from ddc5e74 to f5db0e6 Compare December 17, 2024 07:38
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
89.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranta ranta ranta approved these changes

@vergama vergama vergama approved these changes

Assignees

@matti-lamppu matti-lamppu

Labels
feature Adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matti-lamppu @vergama @ranta