Enhance validation on send application mutation #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matti-lamppu
force-pushed
the
validate-application-section
branch
from
dd44f1c to
56ff3f2
Compare
|
vergama
reviewed
Dec 18, 2024
| msg = "Application organisation must have a core business." | ||
| errors[api_settings.NON_FIELD_ERRORS_KEY].append(msg) | ||
|
|
||
| if OrganizationTypeChoice(organisation.organisation_type) not in allowed_organisation_types: |
There was a problem hiding this comment.
organisation_type is no longer saved for applications, so can't be validated
e.g. https://tilavaraus.test.hel.ninja/admin/tilavarauspalvelu/application/1053/change/ is an application for COMMUNITY but its org.type is the default of COMPANY
vergama
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Looks fine except that the deprecated organisation_type can no longer be validated for a value matching the applicant type. (Probably can't be just migrated away if the values for old applications are wanted for stats, although an empty default would now be better...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Changelog
🧪 Test plan
🚧 Dependencies
🎫 Tickets