Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reservation Unit instructions HTML support #1474

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Reservation Unit instructions HTML support #1474

wants to merge 8 commits into from

Conversation

ranta
Copy link
Collaborator

@ranta ranta commented Dec 18, 2024 •
edited
Loading

🛠️ Changelog

  • Make Reservation Unit instruction texts editable as HTML
  • Convert existing instruction texts to HTML by converting linebreaks to <p> paragraphs
  • Remove empty lines in existing instruction texts
  • Convert HTML instructions to text when they are included in emails

🧪 Test plan

  • Automated tests
  • Try running the migrations locally, see if any errors are found

🚧 Dependencies

  • None

🎫 Tickets

@ranta ranta added fix Fixes a bug improvement Improves an existing feature labels Dec 18, 2024
@ranta ranta self-assigned this Dec 18, 2024
vergama
vergama approved these changes Dec 18, 2024
View reviewed changes
Copy link

@vergama vergama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

matti-lamppu
matti-lamppu reviewed Dec 19, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
matti-lamppu
matti-lamppu reviewed Dec 19, 2024
View reviewed changes
utils/utils.py Outdated Show resolved Hide resolved
matti-lamppu
matti-lamppu reviewed Dec 19, 2024
View reviewed changes
utils/utils.py Outdated Show resolved Hide resolved
matti-lamppu
matti-lamppu approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@matti-lamppu matti-lamppu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would improve the regex a bit but otherwise looks good.

@ranta ranta added the breaking Requires frontend changes label Jan 7, 2025
@ranta ranta force-pushed the instructions branch 2 times, most recently from e56bbb3 to 55163fe Compare January 8, 2025 17:32
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
8.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matti-lamppu matti-lamppu matti-lamppu approved these changes

@vergama vergama vergama approved these changes

Assignees

@ranta ranta

Labels
breaking Requires frontend changes fix Fixes a bug improvement Improves an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ranta @vergama @matti-lamppu