fix: loosen validation rules for new messages (#3222)

City-of-Helsinki · Aug 22, 2024 · 2512a8b · 2512a8b
1 parent f95cc66
commit 2512a8b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/backend/benefit/messages/serializers.py b/backend/benefit/messages/serializers.py
@@ -54,11 +54,7 @@ def validate(self, data):  # noqa: C901
             if company != application.company:
                 raise PermissionDenied(_("You are not allowed to do this action"))
 
-            if (
-                application.status not in self.APPLICANT_MESSAGE_ALLOWED_STATUSES
-                or application.batch
-                or application.archived
-            ):
+            if application.status not in self.APPLICANT_MESSAGE_ALLOWED_STATUSES:
                 raise serializers.ValidationError(
                     _(
                         "Cannot do this action because "

diff --git a/backend/benefit/messages/tests/test_api.py b/backend/benefit/messages/tests/test_api.py
@@ -245,8 +245,8 @@ def test_create_handler_message_invalid(handler_api_client, handling_application
         (ApplicationStatus.ADDITIONAL_INFORMATION_NEEDED, False, 201),
         (ApplicationStatus.ACCEPTED, False, 201),
         (ApplicationStatus.REJECTED, False, 201),
-        (ApplicationStatus.ACCEPTED, True, 400),
-        (ApplicationStatus.REJECTED, True, 400),
+        (ApplicationStatus.ACCEPTED, True, 201),
+        (ApplicationStatus.REJECTED, True, 201),
         (ApplicationStatus.CANCELLED, False, 400),
     ],
 )