Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HL-865: Can't remove drafts as handler #2154

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Conversation

mjturt
Copy link
Collaborator

@mjturt mjturt commented Jul 14, 2023

Description ✨

Once again, the applicant endpoint was used instead of the handler endpoint. Over-aggressive mocking prevented catching this in the development environment.

@codecov-commenter
Copy link

Codecov Report

Merging #2154 (56534e5) into develop (36b198d) will decrease coverage by 15.20%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop    #2154       +/-   ##
============================================
- Coverage    27.00%   11.80%   -15.20%     
============================================
  Files          722      160      -562     
  Lines        14701     4463    -10238     
  Branches      3336     1114     -2222     
============================================
- Hits          3970      527     -3443     
+ Misses       10206     3767     -6439     
+ Partials       525      169      -356     
Impacted Files Coverage Δ
...fit/handler/src/hooks/useDeleteApplicationQuery.ts 0.00% <ø> (ø)

... and 562 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Helsinkibenefit-bf-hdlr is deployed to: https://helsinkibenefit-bf-hdlr-2154.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

Helsinkibenefit-bf-appl is deployed to: https://helsinkibenefit-bf-appl-2154.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

Helsinkibenefit-bf-bknd is deployed to: https://helsinkibenefit-bf-bknd-2154.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

TestCafe result is success for https://helsinkibenefit-bf-appl-2154.test.kuva.hel.ninja! 😆🎉🎉🎉

@sirtawast sirtawast merged commit 8b1dcfd into develop Jul 30, 2023
14 checks passed
@sirtawast sirtawast deleted the HL-865-cant-remove-draft branch July 30, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants