Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some favicons had wrong asset path #2180

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Conversation

sirtawast
Copy link
Collaborator

@sirtawast sirtawast commented Aug 21, 2023

Description ✨

Some favicon assets are 404'ing. Manifest file's path should have /favicons/ in front.

Compare:

@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

[yjdh-helsinkilisa-shared] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2023

Codecov Report

Merging #2180 (4eae5a3) into develop (0906362) will decrease coverage by 13.43%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop    #2180       +/-   ##
============================================
- Coverage    27.60%   14.18%   -13.43%     
============================================
  Files          764      287      -477     
  Lines        15627     7517     -8110     
  Branches      3501     1892     -1609     
============================================
- Hits          4314     1066     -3248     
+ Misses       10741     6165     -4576     
+ Partials       572      286      -286     

see 477 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

[yjdh-helsinkilisa-applicant] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 8 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 56 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

[yjdh-helsinkilisa-handler] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 57 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@github-actions
Copy link
Contributor

Helsinkibenefit-bf-appl is deployed to: https://helsinkibenefit-bf-appl-2180.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

Helsinkibenefit-bf-hdlr is deployed to: https://helsinkibenefit-bf-hdlr-2180.test.kuva.hel.ninja 🚀🚀🚀

@JanneJuhola JanneJuhola merged commit 0d46053 into develop Aug 21, 2023
45 of 50 checks passed
@JanneJuhola JanneJuhola deleted the fix-favicon-paths branch August 21, 2023 08:20
@github-actions
Copy link
Contributor

Helsinkibenefit-bf-bknd is deployed to: https://helsinkibenefit-bf-bknd-2180.test.kuva.hel.ninja 🚀🚀🚀

@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

[yjdh-helsinkilisa-api] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 4 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 17 Code Smells

92.6% 92.6% Coverage
0.0% 0.0% Duplication

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2180.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2180.dev.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2023

TestCafe result is failure for https://helsinkibenefit-bf-appl-2180.test.kuva.hel.ninja! 😿💢💥💥

Check the report on:

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2180.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2180.dev.hel.ninja 😆🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants