-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: some favicons had wrong asset path #2180
Conversation
[yjdh-helsinkilisa-shared] Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov Report
@@ Coverage Diff @@
## develop #2180 +/- ##
============================================
- Coverage 27.60% 14.18% -13.43%
============================================
Files 764 287 -477
Lines 15627 7517 -8110
Branches 3501 1892 -1609
============================================
- Hits 4314 1066 -3248
+ Misses 10741 6165 -4576
+ Partials 572 286 -286 see 477 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
[yjdh-helsinkilisa-applicant] Kudos, SonarCloud Quality Gate passed! 8 Bugs No Coverage information |
[yjdh-helsinkilisa-handler] Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Helsinkibenefit-bf-appl is deployed to: https://helsinkibenefit-bf-appl-2180.test.kuva.hel.ninja 🚀🚀🚀 |
Helsinkibenefit-bf-hdlr is deployed to: https://helsinkibenefit-bf-hdlr-2180.test.kuva.hel.ninja 🚀🚀🚀 |
Helsinkibenefit-bf-bknd is deployed to: https://helsinkibenefit-bf-bknd-2180.test.kuva.hel.ninja 🚀🚀🚀 |
[yjdh-helsinkilisa-api] Kudos, SonarCloud Quality Gate passed! |
API branch is deployed to platta: https://helsinkilisa-pr2180.api.dev.hel.ninja/healthz 🚀🚀🚀 |
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2180.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is failure for https://helsinkibenefit-bf-appl-2180.test.kuva.hel.ninja! 😿💢💥💥 |
APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2180.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-pr2180.dev.hel.ninja 😆🎉🎉🎉 |
Description ✨
Some favicon assets are 404'ing. Manifest file's path should have
/favicons/
in front.Compare: