HL-883 | Fix some issues with opening and locking application on handler's side

[sirtawast]

Description ✨

• Fix seeded applications not being able to be opened / locked by adding more required attachments
• Fix all handler-generated applications throwing a validation violation by skipping user terms validation altogether
• Add toast error reporting if something goes wrong

Note

On handler's side, there's still problems locking or opening an application when terms have been changed and old (although accepted) ones are not in effect anymore. The locking and opening action uses general PUT on /applications/{app_id}/ so it's an error prone process because of rigorous model validation. There's a new ticket for this.

There are two ways to implement a fix:

• Make custom endpoint
  • a new field to set application lock property on/off
  • or just change application status like now (possible status transition problems might arise)
• Loosen the requirements for term consent's approval
• Try using a different Serializer for PATCH (partial_update) actions and implement frontend to call endpoint with PATCH instead of PUT`

[github-actions]

Helsinkibenefit-bf-appl is deployed to: https://helsinkibenefit-bf-appl-2181.test.kuva.hel.ninja 🚀🚀🚀

[github-actions]

Helsinkibenefit-bf-hdlr is deployed to: https://helsinkibenefit-bf-hdlr-2181.test.kuva.hel.ninja 🚀🚀🚀

[github-actions]

Helsinkibenefit-bf-bknd is deployed to: https://helsinkibenefit-bf-bknd-2181.test.kuva.hel.ninja 🚀🚀🚀

[terovirtanen]

API branch is deployed to platta: https://helsinkilisa-pr2181.api.dev.hel.ninja/healthz 🚀🚀🚀

[terovirtanen]

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2181.dev.hel.ninja 🚀🚀🚀

[github-actions]

TestCafe result is success for https://helsinkibenefit-bf-appl-2181.test.kuva.hel.ninja! 😆🎉🎉🎉

[terovirtanen]

API branch is deployed to platta: https://helsinkilisa-pr2181.api.dev.hel.ninja/healthz 🚀🚀🚀

[terovirtanen]

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2181.dev.hel.ninja 🚀🚀🚀

[terovirtanen]

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2181.dev.hel.ninja 🚀🚀🚀

[terovirtanen]

TestCafe result is success for https://helsinkilisa-ui-pr2181.dev.hel.ninja 😆🎉🎉🎉

[codecov-commenter]

Codecov Report

Merging #2181 (d510e25) into develop (0906362) will decrease coverage by 16.05%.
Report is 39 commits behind head on develop.
The diff coverage is 37.50%.

@@             Coverage Diff              @@
##           develop    #2181       +/-   ##
============================================
- Coverage    27.60%   11.55%   -16.05%     
============================================
  Files          764      165      -599     
  Lines        15627     4101    -11526     
  Branches      3501      943     -2558     
============================================
- Hits          4314      474     -3840     
+ Misses       10741     3492     -7249     
+ Partials       572      135      -437     

Files Changed	Coverage Δ
...fit/handler/src/hooks/useUpdateApplicationQuery.ts	54.54% <37.50%> (-2.60%)	⬇️

... and 738 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[terovirtanen]

API branch is deployed to platta: https://helsinkilisa-pr2181.api.dev.hel.ninja/healthz 🚀🚀🚀

[terovirtanen]

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2181.dev.hel.ninja 🚀🚀🚀

[terovirtanen]

API branch is deployed to platta: https://helsinkilisa-pr2181.api.dev.hel.ninja/healthz 🚀🚀🚀

[sonarcloud]

[yjdh] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
0.0% Duplication

[terovirtanen]

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2181.dev.hel.ninja 🚀🚀🚀

[sonarcloud]

[yjdh] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[sonarcloud]

[yjdh] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication