Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HL-890 | Do not obscure view with terms on a11y statement page #2187

Merged
merged 1 commit into from
Aug 28, 2023
Merged

HL-890 | Do not obscure view with terms on a11y statement page #2187

merged 1 commit into from
Aug 28, 2023

Conversation

sirtawast
Copy link
Collaborator

Description ✨

Do not mount terms component if current route is accessibility statement.

@codecov-commenter
Copy link

Codecov Report

Merging #2187 (91e8acd) into develop (8ca325a) will decrease coverage by 13.61%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##           develop    #2187       +/-   ##
============================================
- Coverage    30.12%   16.52%   -13.61%     
============================================
  Files          823      122      -701     
  Lines        16177     2669    -13508     
  Branches      3198      566     -2632     
============================================
- Hits          4874      441     -4433     
+ Misses       10780     2147     -8633     
+ Partials       523       81      -442
Files Changed Coverage Δ
...benefit/applicant/src/components/layout/Layout.tsx 0.00% <0.00%> (ø)

... and 701 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Helsinkibenefit-bf-appl is deployed to: https://helsinkibenefit-bf-appl-2187.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

Helsinkibenefit-bf-hdlr is deployed to: https://helsinkibenefit-bf-hdlr-2187.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

Helsinkibenefit-bf-bknd is deployed to: https://helsinkibenefit-bf-bknd-2187.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

TestCafe result is success for https://helsinkibenefit-bf-appl-2187.test.kuva.hel.ninja! 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2187.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2187.api.dev.hel.ninja/healthz 🚀🚀🚀

@sirtawast sirtawast changed the base branch from develop to main August 28, 2023 07:57
@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2187.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2187.dev.hel.ninja 🚀🚀🚀

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

86.3% 86.3% Coverage
0.0% 0.0% Duplication

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2187.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2187.dev.hel.ninja 😆🎉🎉🎉

@sirtawast sirtawast merged commit 9077729 into main Aug 28, 2023
62 checks passed
@sirtawast sirtawast deleted the hl-890 branch August 28, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjturt mjturt mjturt approved these changes

@rikuke rikuke Awaiting requested review from rikuke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sirtawast @codecov-commenter @terovirtanen @mjturt