Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HL-754: Remove obsolete checkboxes #2188

Merged
merged 1 commit into from
Aug 28, 2023
Merged

HL-754: Remove obsolete checkboxes #2188

merged 1 commit into from
Aug 28, 2023

Conversation

mjturt
Copy link
Collaborator

@mjturt mjturt commented Aug 23, 2023

Description ✨

Removed obsolete checkboxes "kohderyhmätarkistus" and "palkkatuki myönnetty vamman tai sairauden vuoksi".

@codecov-commenter
Copy link

Codecov Report

Merging #2188 (23619a4) into develop (1f1ad98) will decrease coverage by 16.56%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop    #2188       +/-   ##
============================================
- Coverage    27.81%   11.25%   -16.56%     
============================================
  Files          766      165      -601     
  Lines        14878     4086    -10792     
  Branches      3003      941     -2062     
============================================
- Hits          4138      460     -3678     
+ Misses       10263     3492     -6771     
+ Partials       477      134      -343
Files Changed Coverage Δ
...w/employeeView/EmployeeActions/EmployeeActions.tsx 96.15% <ø> (-0.73%) ⬇️
...ubsidyView/PaySubsidyActions/PaysubsidyActions.tsx 100.00% <ø> (ø)

... and 601 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Helsinkibenefit-bf-appl is deployed to: https://helsinkibenefit-bf-appl-2188.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

Helsinkibenefit-bf-bknd is deployed to: https://helsinkibenefit-bf-bknd-2188.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

Helsinkibenefit-bf-hdlr is deployed to: https://helsinkibenefit-bf-hdlr-2188.test.kuva.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2188.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2188.dev.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

TestCafe result is success for https://helsinkibenefit-bf-appl-2188.test.kuva.hel.ninja! 😆🎉🎉🎉

@sirtawast sirtawast changed the base branch from develop to main August 28, 2023 07:56
@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

86.3% 86.3% Coverage
0.0% 0.0% Duplication

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2188.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2188.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2188.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2188.dev.hel.ninja 😆🎉🎉🎉

@mjturt mjturt merged commit 1a80d89 into main Aug 28, 2023
62 checks passed
@mjturt mjturt deleted the HL-754-checkboxes branch August 28, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirtawast sirtawast sirtawast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjturt @codecov-commenter @terovirtanen @sirtawast