Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use swc-jest to improve performance #2876

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

nikomakela
Copy link
Contributor

@nikomakela nikomakela commented Mar 12, 2024

YJDH-690.

Installation guide: https://swc.rs/docs/usage/jest#usage.
Public beanchmarks: https://swc.rs/docs/benchmarks.


Alternative for #2877

Copy link

sonarcloud bot commented Mar 12, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Mar 12, 2024

Copy link

sonarcloud bot commented Mar 12, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Mar 12, 2024

Quality Gate Failed Quality Gate failed for 'yjdh'

Failed conditions
33.3% Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Mar 12, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
23 New issues
7 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.4% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Mar 12, 2024

Copy link

sonarcloud bot commented Mar 12, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Mar 12, 2024

Copy link

sonarcloud bot commented Mar 12, 2024

Copy link

sonarcloud bot commented Mar 12, 2024

Copy link

sonarcloud bot commented Mar 12, 2024

Copy link

sonarcloud bot commented Mar 12, 2024

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://kesaseteli-pr2876.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://tet-pr2876.api.dev.hel.ninja/healthz 🚀🚀🚀

Copy link

sonarcloud bot commented Mar 12, 2024

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2876.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

ADMIN branch is deployed to platta: https://tet-admin-ui-pr2876.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

EMPLOYER branch is deployed to platta: https://kesaseteli-employer-pr2876.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://tet-admin-ui-pr2876.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2876.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-employer-pr2876.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2876.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://kesaseteli-handler-pr2876.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-handler-pr2876.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2876.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

YOUTH branch is deployed to platta: https://tet-youth-ui-pr2876.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://tet-youth-ui-pr2876.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr2876.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

YOUTH branch is deployed to platta: https://kesaseteli-youth-pr2876.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-youth-pr2876.dev.hel.ninja 😆🎉🎉🎉

Copy link
Collaborator

@karisal-anders karisal-anders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the tests faster which might be the issue with the employer tests failing, but looking at the issue the youth part doesn't seem to be running out of the 60s time set by JEST_TIMEOUT:

✕ with changed language (13448 ms)

As all the tests passed for all the projects in the yjdh-monorepo in the CI/CD pipeline I don't think we need to ask for permission from other teams. Please could you take a look at the youth part still as the issue doesn't seem like it's running out of time there? Thank you!

@nikomakela nikomakela merged commit 0dd0203 into main Mar 13, 2024
197 checks passed
@nikomakela nikomakela deleted the yjdh-690-use-swc-jest branch March 13, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants