Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hl 1140 ahjo title #2879

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Hl 1140 ahjo title #2879

merged 2 commits into from
Mar 15, 2024

Conversation

rikuke
Copy link
Collaborator

@rikuke rikuke commented Mar 14, 2024

Description ✨

AHJO UI has a 151 character limit for the case title, this PR makes the title shorter so it should fit into that limit.

Issues πŸ›

Testing βš—οΈ

Screenshots πŸ“Έ

Additional notes πŸ—’οΈ

@@ -11,13 +11,19 @@

MANNER_OF_RECEIPT = "sΓ€hkΓΆinen asiointi"

def prepare_title(application: Application) -> str:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit can be ignored, truncating the title conditionally is not needed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot that I had a previous commit and did not amend the actual solution commit.

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2879.api.dev.hel.ninja/healthz πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2879.api.dev.hel.ninja/healthz πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2879.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2879.dev.hel.ninja πŸ˜†πŸŽ‰πŸŽ‰πŸŽ‰

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2879.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr2879.dev.hel.ninja πŸ˜ΏπŸ’’πŸ’₯πŸ’₯

2 similar comments
@terovirtanen
Copy link
Contributor

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr2879.dev.hel.ninja πŸ˜ΏπŸ’’πŸ’₯πŸ’₯

@terovirtanen
Copy link
Contributor

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr2879.dev.hel.ninja πŸ˜ΏπŸ’’πŸ’₯πŸ’₯

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2879.api.dev.hel.ninja/healthz πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2879.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2879.dev.hel.ninja πŸ˜†πŸŽ‰πŸŽ‰πŸŽ‰

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2879.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr2879.dev.hel.ninja πŸ˜ΏπŸ’’πŸ’₯πŸ’₯

@terovirtanen
Copy link
Contributor

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr2879.dev.hel.ninja πŸ˜ΏπŸ’’πŸ’₯πŸ’₯

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2879.api.dev.hel.ninja/healthz πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2879.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr2879.dev.hel.ninja πŸ˜ΏπŸ’’πŸ’₯πŸ’₯

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2879.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2879.dev.hel.ninja πŸ˜†πŸŽ‰πŸŽ‰πŸŽ‰

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2879.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr2879.dev.hel.ninja πŸ˜ΏπŸ’’πŸ’₯πŸ’₯

Copy link

sonarcloud bot commented Mar 15, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Mar 15, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Mar 15, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
23 New issues
7 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.4% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Mar 15, 2024

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2879.api.dev.hel.ninja/healthz πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2879.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2879.dev.hel.ninja πŸ˜†πŸŽ‰πŸŽ‰πŸŽ‰

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2879.dev.hel.ninja πŸš€πŸš€πŸš€

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr2879.dev.hel.ninja πŸ˜†πŸŽ‰πŸŽ‰πŸŽ‰

@rikuke rikuke merged commit 7f12022 into main Mar 15, 2024
65 checks passed
@rikuke rikuke deleted the HL-1140-ahjo-title branch March 15, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants