feat: perform "back" actions througout the app using centralized hook (hl-1276) #3394

sirtawast · 2024-10-03T12:14:38Z

Description ✨

Handler side changes. Back buttons each had custom function calls to next router. Use centralized hook to perform these actions with different logic and use cases.

Use one function to invoke when Back buttons are pressed
- Usually, go back from application to corresponding tab with matching status
- Go to archive if the application is archived
  - One special case where similar applications were searched for with ?appNo=123456 param
- Go to alterations if it was previously visited
- If no other means is provided, route back to root of the app
Browsing is now recorded to window.sessionStorage to allow for history tracking and usage where needed
Fix one key prop issue

terovirtanen · 2024-10-03T12:39:53Z

API branch is deployed to platta: https://kesaseteli-pr3394.api.dev.hel.ninja/healthz 🚀🚀🚀

sonarcloud · 2024-10-04T06:54:02Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

…ns througout the app

terovirtanen · 2024-10-10T06:20:06Z

YJDH-TET-API branch is deployed to platta: https://yjdh-tet-pr3394.api.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-10-10T06:27:38Z

ADMIN is deployed to platta: https://yjdh-tet-admin-ui-pr3394.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-10-10T06:28:21Z

YOUTH branch is deployed to platta: https://yjdh-tet-youth-ui-pr3394.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-10-10T06:31:29Z

TestCafe result is success for https://yjdh-tet-admin-ui-pr3394.dev.hel.ninja 😆🎉🎉🎉

terovirtanen · 2024-10-10T06:31:58Z

TestCafe result is success for https://yjdh-tet-youth-ui-pr3394.dev.hel.ninja 😆🎉🎉🎉

terovirtanen · 2024-10-10T07:02:09Z

API branch is deployed to platta: https://helsinkilisa-pr3394.api.dev.hel.ninja/healthz 🚀🚀🚀

terovirtanen · 2024-10-10T07:02:09Z

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3394.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-10-10T07:02:10Z

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3394.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-10-10T07:09:43Z

TestCafe result is success for https://helsinkilisa-ui-pr3394.dev.hel.ninja 😆🎉🎉🎉

terovirtanen · 2024-10-10T07:10:34Z

TestCafe result is success for https://helsinkilisa-ui-handler-pr3394.dev.hel.ninja 😆🎉🎉🎉

terovirtanen · 2024-10-17T06:22:55Z

YJDH-TET-API branch is deployed to platta: https://yjdh-tet-pr3394.api.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-10-17T06:25:45Z

YOUTH branch is deployed to platta: https://yjdh-tet-youth-ui-pr3394.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-10-17T06:28:48Z

ADMIN is deployed to platta: https://yjdh-tet-admin-ui-pr3394.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-10-17T06:29:29Z

TestCafe result is success for https://yjdh-tet-youth-ui-pr3394.dev.hel.ninja 😆🎉🎉🎉

terovirtanen · 2024-10-17T06:33:07Z

TestCafe result is success for https://yjdh-tet-admin-ui-pr3394.dev.hel.ninja 😆🎉🎉🎉

terovirtanen · 2024-10-17T06:43:11Z

API branch is deployed to platta: https://helsinkilisa-pr3394.api.dev.hel.ninja/healthz 🚀🚀🚀

terovirtanen · 2024-10-21T06:32:14Z

YJDH-TET-API branch is deployed to platta: https://yjdh-tet-pr3394.api.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-10-21T06:35:59Z

YOUTH branch is deployed to platta: https://yjdh-tet-youth-ui-pr3394.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-10-21T06:38:26Z

ADMIN is deployed to platta: https://yjdh-tet-admin-ui-pr3394.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-10-21T06:39:52Z

TestCafe youth result is failed for https://yjdh-tet-youth-ui-pr3394.dev.hel.ninja 😿💢💥💥

terovirtanen · 2024-10-21T06:41:32Z

TestCafe admin result is failed for https://yjdh-tet-admin-ui-pr3394.dev.hel.ninja 😿💢💥💥

sonarcloud · 2024-10-21T06:54:32Z

Quality Gate failed for 'yjdh'

Failed conditions
8.8% Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

sonarcloud · 2024-10-21T06:55:27Z

Quality Gate passed for 'yjdh'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

terovirtanen · 2024-10-21T06:57:36Z

API branch is deployed to platta: https://kesaseteli-pr3394.api.dev.hel.ninja/healthz 🚀🚀🚀

sonarcloud · 2024-10-21T06:57:41Z

Quality Gate passed for 'yjdh'

Issues
14 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud · 2024-10-21T06:57:52Z

Quality Gate failed for 'yjdh'

Failed conditions
33.3% Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

sonarcloud · 2024-10-21T06:58:40Z

Quality Gate passed for 'yjdh'

Issues
41 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.8% Duplication on New Code

See analysis details on SonarCloud

sonarcloud · 2024-10-21T06:59:03Z

Quality Gate passed for 'yjdh'

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud · 2024-10-21T07:00:01Z

Quality Gate passed for 'yjdh'

Issues
53 New issues
8 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.2% Duplication on New Code

See analysis details on SonarCloud

sonarcloud · 2024-10-21T07:00:38Z

Quality Gate passed for 'yjdh'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

terovirtanen · 2024-10-21T07:01:29Z

YJDH-TET-API branch is deployed to platta: https://yjdh-tet-pr3394.api.dev.hel.ninja 🚀🚀🚀

sonarcloud · 2024-10-21T07:02:28Z

Quality Gate passed for 'yjdh-tet-shared'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud · 2024-10-21T07:03:24Z

Quality Gate passed for 'yjdh'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud · 2024-10-21T07:04:01Z

Quality Gate passed for 'yjdh'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

terovirtanen · 2024-10-21T07:05:24Z

YOUTH branch is deployed to platta: https://yjdh-tet-youth-ui-pr3394.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-10-21T07:09:08Z

ADMIN is deployed to platta: https://yjdh-tet-admin-ui-pr3394.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-10-21T07:09:29Z

TestCafe youth result is failed for https://yjdh-tet-youth-ui-pr3394.dev.hel.ninja 😿💢💥💥

sonarcloud · 2024-10-21T07:10:29Z

Quality Gate passed for 'yjdh'

Issues
27 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

terovirtanen · 2024-10-21T07:12:39Z

TestCafe admin result is failed for https://yjdh-tet-admin-ui-pr3394.dev.hel.ninja 😿💢💥💥

terovirtanen · 2024-10-21T07:15:16Z

EMPLOYER branch is deployed to platta: https://kesaseteli-employer-pr3394.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-10-21T07:19:06Z

TestCafe employer result is failed for https://kesaseteli-employer-pr3394.dev.hel.ninja 😿💢💥💥

terovirtanen · 2024-10-21T07:26:19Z

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3394.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-10-21T07:26:48Z

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3394.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-10-21T07:26:50Z

API branch is deployed to platta: https://helsinkilisa-pr3394.api.dev.hel.ninja/healthz 🚀🚀🚀

terovirtanen · 2024-10-21T07:45:40Z

TestCafe applicant result is failed for https://helsinkilisa-ui-pr3394.dev.hel.ninja 😿💢💥💥

terovirtanen · 2024-10-21T07:46:21Z

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr3394.dev.hel.ninja 😿💢💥💥

sirtawast requested a review from rikuke October 3, 2024 12:15

sirtawast force-pushed the hl-1276 branch from db25521 to 25a96f0 Compare October 3, 2024 12:30

sirtawast force-pushed the hl-1276 branch from 25a96f0 to b657400 Compare October 4, 2024 06:44

rikuke approved these changes Oct 8, 2024

View reviewed changes

feat: useRouterNavigation hook to centralize and perform "back" actio…

82cd488

…ns througout the app

sirtawast force-pushed the hl-1276 branch from b657400 to 82cd488 Compare October 10, 2024 06:08

Merge branch 'main' into hl-1276

1dcfcb9

fix: broken test caused by removing currency decimals

c37925d

fixup! Merge branch 'main' into hl-1276

14e543c

feat: perform "back" actions througout the app using centralized hook (hl-1276) #3394

Are you sure you want to change the base?

feat: perform "back" actions througout the app using centralized hook (hl-1276) #3394

Conversation

sirtawast commented Oct 3, 2024 • edited Loading

Description ✨

terovirtanen commented Oct 3, 2024

sonarcloud bot commented Oct 4, 2024

Quality Gate passed

terovirtanen commented Oct 10, 2024

terovirtanen commented Oct 10, 2024

terovirtanen commented Oct 10, 2024

terovirtanen commented Oct 10, 2024

TestCafe result is success for https://yjdh-tet-admin-ui-pr3394.dev.hel.ninja 😆🎉🎉🎉

terovirtanen commented Oct 10, 2024

TestCafe result is success for https://yjdh-tet-youth-ui-pr3394.dev.hel.ninja 😆🎉🎉🎉

terovirtanen commented Oct 10, 2024

terovirtanen commented Oct 10, 2024

terovirtanen commented Oct 10, 2024

terovirtanen commented Oct 10, 2024

TestCafe result is success for https://helsinkilisa-ui-pr3394.dev.hel.ninja 😆🎉🎉🎉

terovirtanen commented Oct 10, 2024

TestCafe result is success for https://helsinkilisa-ui-handler-pr3394.dev.hel.ninja 😆🎉🎉🎉

terovirtanen commented Oct 17, 2024

terovirtanen commented Oct 17, 2024

terovirtanen commented Oct 17, 2024

terovirtanen commented Oct 17, 2024

TestCafe result is success for https://yjdh-tet-youth-ui-pr3394.dev.hel.ninja 😆🎉🎉🎉

terovirtanen commented Oct 17, 2024

TestCafe result is success for https://yjdh-tet-admin-ui-pr3394.dev.hel.ninja 😆🎉🎉🎉

terovirtanen commented Oct 17, 2024

terovirtanen commented Oct 21, 2024

terovirtanen commented Oct 21, 2024

terovirtanen commented Oct 21, 2024

terovirtanen commented Oct 21, 2024

TestCafe youth result is failed for https://yjdh-tet-youth-ui-pr3394.dev.hel.ninja 😿💢💥💥

terovirtanen commented Oct 21, 2024

TestCafe admin result is failed for https://yjdh-tet-admin-ui-pr3394.dev.hel.ninja 😿💢💥💥

sonarcloud bot commented Oct 21, 2024

Quality Gate failed for 'yjdh'

sonarcloud bot commented Oct 21, 2024

Quality Gate passed for 'yjdh'

terovirtanen commented Oct 21, 2024

sonarcloud bot commented Oct 21, 2024

Quality Gate passed for 'yjdh'

sonarcloud bot commented Oct 21, 2024

Quality Gate failed for 'yjdh'

sonarcloud bot commented Oct 21, 2024

Quality Gate passed for 'yjdh'

sonarcloud bot commented Oct 21, 2024

Quality Gate passed for 'yjdh'

sonarcloud bot commented Oct 21, 2024

Quality Gate passed for 'yjdh'

sonarcloud bot commented Oct 21, 2024

Quality Gate passed for 'yjdh'

terovirtanen commented Oct 21, 2024

sonarcloud bot commented Oct 21, 2024

Quality Gate passed for 'yjdh-tet-shared'

sonarcloud bot commented Oct 21, 2024

Quality Gate passed for 'yjdh'

sonarcloud bot commented Oct 21, 2024

Quality Gate passed for 'yjdh'

terovirtanen commented Oct 21, 2024

terovirtanen commented Oct 21, 2024

terovirtanen commented Oct 21, 2024

TestCafe youth result is failed for https://yjdh-tet-youth-ui-pr3394.dev.hel.ninja 😿💢💥💥

sonarcloud bot commented Oct 21, 2024

Quality Gate passed for 'yjdh'

terovirtanen commented Oct 21, 2024

TestCafe admin result is failed for https://yjdh-tet-admin-ui-pr3394.dev.hel.ninja 😿💢💥💥

terovirtanen commented Oct 21, 2024

terovirtanen commented Oct 21, 2024

TestCafe employer result is failed for https://kesaseteli-employer-pr3394.dev.hel.ninja 😿💢💥💥

terovirtanen commented Oct 21, 2024

terovirtanen commented Oct 21, 2024

terovirtanen commented Oct 21, 2024

terovirtanen commented Oct 21, 2024

TestCafe applicant result is failed for https://helsinkilisa-ui-pr3394.dev.hel.ninja 😿💢💥💥

terovirtanen commented Oct 21, 2024

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr3394.dev.hel.ninja 😿💢💥💥

sirtawast commented Oct 3, 2024 •

edited

Loading