Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: application history did not include change reasons with 0 diffs (hl-1484) #3413

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

sirtawast
Copy link
Collaborator

@sirtawast sirtawast commented Oct 8, 2024

Description ✨

Expose change history sets with zero differences but mere comment to the API response. This is used as a tool for the handler when commenting on attachment changes (or anything else, really).

As a bonus, rename some confusing variables.

@sirtawast sirtawast requested a review from rikuke October 8, 2024 09:34
@sirtawast sirtawast changed the title Hl 1484 fix: application history did not include change reasons with 0 diffs (hl-1484) Oct 8, 2024
Copy link

sonarcloud bot commented Oct 8, 2024

Copy link

sonarcloud bot commented Oct 8, 2024

Copy link

sonarcloud bot commented Oct 8, 2024

Copy link

sonarcloud bot commented Oct 8, 2024

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr3413.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3413.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3413.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr3413.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr3413.dev.hel.ninja 😆🎉🎉🎉

@JanneJuhola JanneJuhola merged commit 031d5bf into main Oct 9, 2024
65 checks passed
@JanneJuhola JanneJuhola deleted the hl-1484 branch October 9, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants