Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add talpa status and decision date to apps which are "in payment" state (hl-1307) #3444

Merged
merged 1 commit into from
Oct 16, 2024
Merged

feat: add talpa status and decision date to apps which are "in payment" state (hl-1307) #3444

merged 1 commit into from
Oct 16, 2024

Conversation

sirtawast
Copy link
Collaborator

@sirtawast sirtawast commented Oct 15, 2024 •
edited
Loading

Description ✨

Add two new columns to application list for applications which are "in payment". That means decision making has progressed to accepted state. application status is accepted, batch status is accepted and batch has a decision date.

image

Testing

  1. Get applications to "in payment" state, see up for details.
  2. Set application's talpa status to any of not_sent_to_talpa rejected_by_talpa successfully_sent_to_talpa
  3. Go to https://localhost:3100/?tab=5

@sirtawast sirtawast requested a review from rikuke October 15, 2024 07:48
@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr3444.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3444.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3444.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr3444.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr3444.dev.hel.ninja 😆🎉🎉🎉

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 15, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
41 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.8% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 15, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
14 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 15, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
50 New issues
8 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.2% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 15, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
27 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr3444.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3444.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3444.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr3444.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr3444.dev.hel.ninja 😆🎉🎉🎉

@JanneJuhola JanneJuhola merged commit 3fd9088 into main Oct 16, 2024
65 checks passed
@JanneJuhola JanneJuhola deleted the hl-1307 branch October 16, 2024 09:41
This was referenced Oct 16, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikuke rikuke rikuke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sirtawast @terovirtanen @rikuke @JanneJuhola