Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parcel-bundler and fontawesome to the list of dependencies. #3

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

elenm
Copy link

@elenm elenm commented May 26, 2021

This allows yarn start to work without requiring manual install of these dependencies. Also moves the fontawesome import from the HTML file to the JS file, such that it is not necessary to copy fontawesome to a local directory to run the app.

This allows `yarn start` to work without requiring manual install of these dependencies. Also moves the fontawesome import from the HTML file to the JS file, such that it is not necessary to copy fontawesome to a `local` directory to run the app.
Copy link
Member

@jedgar1mx jedgar1mx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fontawesome is not added as a dependency since the drupal appliaction already has a specific version installed. We don't want to add it to the build bundle.

@jedgar1mx jedgar1mx marked this pull request as draft June 8, 2021 17:01
@jedgar1mx jedgar1mx marked this pull request as ready for review June 8, 2021 17:01
@jedgar1mx jedgar1mx marked this pull request as draft June 8, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants