Merge pull request #33 from CityOfZion/CU-86a23awd8

CU-86a23awd8 - Fix lint errors and lint script that is not working on macos
CityOfZion · Jan 30, 2024 · 4a3f0d8 · 4a3f0d8
2 parents 210e699 + 5714f15
commit 4a3f0d8
Show file tree

Hide file tree

Showing 10 changed files with 34 additions and 6 deletions.
diff --git a/common/autoinstallers/rush-format/src/utils.ts b/common/autoinstallers/rush-format/src/utils.ts
@@ -11,14 +11,20 @@ function getAllPaths(): string[] {
 export function runCommandInEachPackage(cmd: string) {
   let error = false
   const packages = getAllPaths()
+
   for (const lib of packages) {
     try {
       const pathLib = path.posix.join(packagesPath, lib)
+
+      const isDirectory = fs.lstatSync(pathLib).isDirectory()
+      if (!isDirectory) continue
+
       execSync(`${cmd}`, { cwd: pathLib, stdio: 'inherit' })
-    } catch {
+    } catch (error) {
       error = true
     }
   }
+
   if (error) {
     console.error('\nPlease, check the errors above before committing/pushing!\n')
     process.exitCode = 1

diff --git a/common/changes/@cityofzion/bs-neo-legacy/CU-86a23awd8_2024-01-30-16-05.json b/common/changes/@cityofzion/bs-neo-legacy/CU-86a23awd8_2024-01-30-16-05.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@cityofzion/bs-neo-legacy",
+      "comment": "Fixed lint errors that were preventing the build",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@cityofzion/bs-neo-legacy"
+}
diff --git a/common/changes/@cityofzion/bs-neo3/CU-86a23awd8_2024-01-30-16-05.json b/common/changes/@cityofzion/bs-neo3/CU-86a23awd8_2024-01-30-16-05.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@cityofzion/bs-neo3",
+      "comment": "Fixed lint errors that were preventing the build",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@cityofzion/bs-neo3"
+}
diff --git a/common/git-hooks/pre-commit b/common/git-hooks/pre-commit
diff --git a/common/git-hooks/pre-push b/common/git-hooks/pre-push
diff --git a/packages/bs-neo-legacy/src/BSNeoLegacy.ts b/packages/bs-neo-legacy/src/BSNeoLegacy.ts
@@ -27,7 +27,8 @@ import { keychain } from '@cityofzion/bs-asteroid-sdk'
 import { DoraESNeoLegacy } from './DoraESNeoLegacy'
 
 export class BSNeoLegacy<BSCustomName extends string = string>
-  implements BlockchainService, BSClaimable, BSWithExplorerService {
+  implements BlockchainService, BSClaimable, BSWithExplorerService
+{
   readonly blockchainName: BSCustomName
   readonly feeToken: Token
   readonly claimToken: Token

diff --git a/packages/bs-neo-legacy/src/__tests__/BDSNeoLegacy.spec.ts b/packages/bs-neo-legacy/src/__tests__/BDSNeoLegacy.spec.ts
@@ -108,7 +108,7 @@ describe('BDSNeoLegacy', () => {
           decimals: expect.any(Number),
         },
       })
-      expect(balance.token.hash.startsWith("0x")).toBeFalsy()
+      expect(balance.token.hash.startsWith('0x')).toBeFalsy()
     })
   })
 

diff --git a/packages/bs-neo-legacy/src/assets/tokens/common.json b/packages/bs-neo-legacy/src/assets/tokens/common.json
@@ -11,4 +11,4 @@
     "hash": "c56f33fc6ecfcd0c225c4ab356fee59390af8560be0e930faebe74a6daff7c9b",
     "decimals": 0
   }
-]
+]
diff --git a/packages/bs-neo-legacy/src/assets/tokens/mainnet.json b/packages/bs-neo-legacy/src/assets/tokens/mainnet.json
@@ -463,4 +463,4 @@
     "hash": "3e09e602eeeb401a2fec8e8ea137d59aae54a139",
     "decimals": 8
   }
-]
+]
diff --git a/packages/bs-neo3/src/BSNeo3.ts b/packages/bs-neo3/src/BSNeo3.ts
@@ -33,7 +33,8 @@ import { keychain } from '@cityofzion/bs-asteroid-sdk'
 import { DoraESNeo3 } from './DoraESNeo3'
 
 export class BSNeo3<BSCustomName extends string = string>
-  implements BlockchainService, BSClaimable, BSWithNameService, BSCalculableFee, BSWithNft, BSWithExplorerService {
+  implements BlockchainService, BSClaimable, BSWithNameService, BSCalculableFee, BSWithNft, BSWithExplorerService
+{
   readonly blockchainName: BSCustomName
   readonly feeToken: Token
   readonly claimToken: Token
-Original file line number
+Diff line change
@@ Expand Up / @@ -108,7 +108,7 @@ describe('BDSNeoLegacy', () => { @@
               decimals: expect.any(Number),
             },
           })
-          expect(balance.token.hash.startsWith("0x")).toBeFalsy()
+          expect(balance.token.hash.startsWith('0x')).toBeFalsy()
         })
       })
@@ Expand Down @@