CU-86drpncjw - Refactor example_tests/test_htlc.py to use BoaConstructor #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
meevee98
suggested changes
Mar 25, 2024
Comment on lines
318
to
324
| self.assertEqual(htlc, filtered_transfer_events[0].source) | ||
| self.assertEqual(person_a, filtered_transfer_events[0].destination) | ||
| self.assertEqual(transferred_amount_neo, filtered_transfer_events[0].amount) | ||
|
|
||
| self.assertEqual(htlc, filtered_transfer_events[1].source) | ||
| self.assertEqual(person_b, filtered_transfer_events[1].destination) | ||
| self.assertEqual(transferred_amount_gas, filtered_transfer_events[1].amount) |
There was a problem hiding this comment.
when there's more than one event expected, you should use variables to let the test more readable
Suggested change
| self.assertEqual(htlc, filtered_transfer_events[0].source) | |
| self.assertEqual(person_a, filtered_transfer_events[0].destination) | |
| self.assertEqual(transferred_amount_neo, filtered_transfer_events[0].amount) | |
| self.assertEqual(htlc, filtered_transfer_events[1].source) | |
| self.assertEqual(person_b, filtered_transfer_events[1].destination) | |
| self.assertEqual(transferred_amount_gas, filtered_transfer_events[1].amount) | |
| refund_A, refund_B = filtered_transfer_events | |
| self.assertEqual(htlc, refund_A.source) | |
| self.assertEqual(person_a, refund_A.destination) | |
| self.assertEqual(transferred_amount_neo, refund_A.amount) | |
| self.assertEqual(htlc, refund_B.source) | |
| self.assertEqual(person_b, refund_B.destination) | |
| self.assertEqual(transferred_amount_gas, refund_B.amount) |
| return_type=bool, | ||
| target_contract=constants.GAS_SCRIPT) | ||
|
|
||
| await asyncio.sleep(self.REFUND_WAIT_TIME) |
There was a problem hiding this comment.
it seems that all asyncio.sleep calls in the test case use the same arguments, so you can move it to a helper method call.
async def wait_refund_time():
return await asyncio.slepp(self.REFUND_WAIT_TIME)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
example_tests/test_htlc.pyfiles to useBoaTestCasein place ofBoaTestfor unit testing.