Remove Number of Transactions & Total Transactions from Activity Page #2612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jseagrave21
force-pushed
the
remove_totalCount
branch
from
2fd36f8
to
ad01dac
Compare
jseagrave21
force-pushed
the
remove_totalCount
branch
from
ad01dac
to
2c9adff
Compare
|
Requesting a review. @melanke @raulduartep @comountainclimber |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) from Trello/Github does this address?
#2602
What problem does this PR solve?
This fixes the problem of displaying an incorrect total number of transactions for a wallet address. This problem stems from inconsistencies with
totalCount. Refer to the issue for more details.How did you solve this problem?
I removed the number of transactions (
transactions.length) and the total number of transactions (count) from the Activity page. Then I added logic to ensure the Load More button is disabled when there are no more transactions to load. Specifically, now we check to see if there is a next page after we load each page from Dora. If there isn't, thecountis set to the total number of transactions loaded (entries.length). The new logic does not affect the Neo Legacy logic, so it still disables the Load More button accurately usingcountas before.How did you make sure your solution works?
Live testing with a Neo Legacy address,and two Neo3 addresses, one of which only had a single page of transactions.
Are there any special changes in the code that we should be aware of?
Nothing additional.
Is there anything else we should know?
No.