Landing Page - Make Requested Changes #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added translate markups to strings. Delete commented code in landing.css Ran landing.css through a CSS beautifier.
Fixed issue with translate not being recognized loading i18n
Fixed translate for Developers near end of file.
brylie
requested changes
Nov 15, 2022
|
Screenshots of front page
|
brylie
requested changes
Nov 17, 2022
|
Conflicts resolved. |
|
There are too many results to compare View more on Code Climate. |
brylie
approved these changes
Nov 18, 2022
|
@all-contributors please add @rdhoge for code |
|
I've put up a pull request to add @rdhoge! 🎉 |
|
@all-contributors please add @ApoorvaKashyap for code |
|
@ApoorvaKashyap already contributed before to code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1420
Description
Addresses requests to add translate tags and clean up CSS code for pull request #1420.